Oh well, I did have a few more suggestions in the end.

View Change

4 comments:

• File cli_classic.c:

  • Patch Set #6, Line 130: {"ifd", 0, NULL, 0x0100},

    wouldn't it make more sense to use the values from the enum here?

  • Patch Set #6, Line 132: {"flash-contents", 1, NULL, 0x0101},

    ditto

  • Patch Set #6, Line 253: case 0x0101:

    ditto, and there's probably a 0x0100 that's around but not shown in the context that should also be changed.

• File flashrom.c:

  • Patch Set #6, Line 2395: if (refcontents && oldcontents) {

    Extra padding should be removed.

To view, visit change 23263. To unsubscribe, or for help writing mail filters, visit settings.