Attention is currently required from: Brian Norris, Thomas Heijligen.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashrom_tester: Correct "WP screw" message ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5: Thank you for the updates! Yes, they did look incorrect. My apologies for the delayed review.
I also did some internal research and confirmed no other tools rely on this wording currently. We should be safe to change it without breaking anything.
While we're at it, why not change the wording to make it clearer? For instance, we could use "remove/restore the WP screw", "unscrew/screw the WP screw", or "open/lock the WP screw".
What do you think? Would that be clearer?
-
Hsuan-ting Chen (Code Review)