Attention is currently required from: Brian Norris, Thomas Heijligen.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
View Change
1 comment:
Patchset:
Patch Set #5:
Thank you for the updates! Yes, they did look incorrect. My apologies for the delayed review.
I also did some internal research and confirmed no other tools rely on this wording currently. We should be safe to change it without breaking anything.
While we're at it, why not change the wording to make it clearer? For instance, we could use "remove/restore the WP screw", "unscrew/screw the WP screw", or "open/lock the WP screw".
What do you think? Would that be clearer?
To view, visit change 82083. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Evan Benn <evanbenn@gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Brian Norris <briannorris@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Mon, 29 Apr 2024 11:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment