Nico Huber has posted comments on this change. ( https://review.coreboot.org/23260 )
Change subject: edi: Add dummy read to ensure proper detection of ENE chips ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Well, it's really a lot of boilerplate and commentary for something that actually could be a one-liner with a one-line comment. Your choice.
https://review.coreboot.org/#/c/23260/3/edi.c File edi.c:
https://review.coreboot.org/#/c/23260/3/edi.c@166 PS3, Line 166: static void edi_draw_attention(struct flashctx *flash)
Theoretically
we could put every function call into its own function and comment it twice. It's really a little too much here, IMHO.