Well, it's really a lot of boilerplate and commentary for something
that actually could be a one-liner with a one-line comment. Your
choice.
Patch set 6:Code-Review +2
View Change
1 comment:
File edi.c:
Patch Set #3, Line 166: static void edi_draw_attention(struct flashctx *flash)
Theoretically
we could put every function call into its own function and comment
it twice. It's really a little too much here, IMHO.
To view, visit change 23260. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9
Gerrit-Change-Number: 23260
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 22:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes