[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Jean THOMAS, Alexander Goncharov.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )

Change subject: dirtyjtag: Add DirtyJTAG programmer
......................................................................

Patch Set 10:

(4 comments)

File dirtyjtag_spi.c:

https://review.coreboot.org/c/flashrom/+/67878/comment/9ae80495_5cb1f9e6 
PS10, Line 79: unsigned char *
Doesn't this drop the `const` property of the data pointed by the pointer? Shouldn't it be `const unsigned char *` instead?

https://review.coreboot.org/c/flashrom/+/67878/comment/1df383af_6c9e4bd0 
PS10, Line 152: 30 * i
This is because each transfer is 30 bytes, right? How about addding a constant inside the loop:

const size_t xfer_offset = 30 * i;

https://review.coreboot.org/c/flashrom/+/67878/comment/a90eb49a_9e828629 
PS10, Line 154: (const char *)transfer_buffer
Why are there casts here and inside the functions themselves? As these functions' signatures do not depend on external constraints (e.g. used as value for a function pointer), we can retype the parameters to avoid the double cast.

https://review.coreboot.org/c/flashrom/+/67878/comment/5e6150bb_b3481de1 
PS10, Line 160: i * 30
ditto