Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Jean THOMAS, Alexander Goncharov.

View Change

4 comments:

• File dirtyjtag_spi.c:

  • Patch Set #10, Line 79: unsigned char *

    Doesn't this drop the `const` property of the data pointed by the pointer? Shouldn't it be `const unsigned char *` instead?

  • Patch Set #10, Line 152: 30 * i

    This is because each transfer is 30 bytes, right? How about addding a constant inside the loop:

     const size_t xfer_offset = 30 * i;

  • Patch Set #10, Line 154: (const char *)transfer_buffer

    Why are there casts here and inside the functions themselves? As these functions' signatures do not depend on external constraints (e.g. used as value for a function pointer), we can retype the parameters to avoid the double cast.

  • Patch Set #10, Line 160: i * 30

    ditto

To view, visit change 67878. To unsubscribe, or for help writing mail filters, visit settings.