Attention is currently required from: Nikolai Artemiev, Evan Benn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68127 )
Change subject: ps25f.c: Fix UB on shift ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68127/comment/c5abe207_329b2275 PS1, Line 7: UB There's enough space to use the full form: `undefined behavior` (or `undefined behaviour`, pick your poison 😄)
https://review.coreboot.org/c/flashrom/+/68127/comment/f51c73f9_d7164d33 PS1, Line 7: p spurious `p`
https://review.coreboot.org/c/flashrom/+/68127/comment/9a62eaa2_4b8b8d7d PS1, Line 9: 24 We had a teacher that would say "24 what? Potatoes?". Maybe reword this sentence as follows:
dev_id, a u8, was shifted left 24 bits.
-
Angel Pons (Code Review)