Attention is currently required from: Nikolai Artemiev, Evan Benn.

Patch set 1:Code-Review +2

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 7: UB

    There's enough space to use the full form: `undefined behavior` (or `undefined behaviour`, pick your poison 😄)

  • Patch Set #1, Line 7: p

    spurious `p`

  • Patch Set #1, Line 9: 24

    We had a teacher that would say "24 what? Potatoes?". Maybe reword this sentence as follows:

     dev_id, a u8, was shifted left 24 bits.

To view, visit change 68127. To unsubscribe, or for help writing mail filters, visit settings.