Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash() ......................................................................
Patch Set 13: Code-Review+2
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/9e69b4d4_43df1e6b PS13, Line 868: goto notfound; Please a line after that
File w29ee011.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/003650e6_4db81a3d PS13, Line 25: override_chip || strcmp(override_chip, chip_name) Just an idea, a nit: How about moving this to a variable `can_override`? This also would allow us having one path regarding the returns. On the other side this way it's more clear what is returned. Not sure what's better. Feel free to mark as resolved if you think it's fine this way 😊