Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

Patch set 13:Code-Review +2

View Change

2 comments:

• File flashrom.c:

  • Patch Set #13, Line 868: goto notfound;

    Please a line after that

• File w29ee011.c:

  • Patch Set #13, Line 25: override_chip || strcmp(override_chip, chip_name)

    Just an idea, a nit: How about moving this to a variable `can_override`? This also would allow us having one path regarding the returns. On the other side this way it's more clear what is returned. Not sure what's better. Feel free to mark as resolved if you think it's fine this way 😊

To view, visit change 67091. To unsubscribe, or for help writing mail filters, visit settings.