[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern

[Miklós Márton (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )

Change subject: ni845x_spi: refactor singleton states into reentrant pattern
......................................................................

Patch Set 3:

(5 comments)

File ni845x_spi.c:

https://review.coreboot.org/c/flashrom/+/72160/comment/9e395d63_d624c7df 
PS3, Line 432: 	const struct ni845x_spi_data *data = flash->mst->spi.data;
I think data shall not be const here. See comments below.

https://review.coreboot.org/c/flashrom/+/72160/comment/2b4414b5_df4dd392 
PS3, Line 456: 							       &io_voltage_in_mV,
The io_voltage_in_mV is not defined anymore. data->io_voltage_in_mV is intended to be used here if I am not mistaken.

https://review.coreboot.org/c/flashrom/+/72160/comment/001dbd6f_fc7c4c5a 
PS3, Line 481: 							       &io_voltage_in_mV,
Same as in line 456

https://review.coreboot.org/c/flashrom/+/72160/comment/f08e2e7d_4c961ca7 
PS3, Line 566: 	unsigned char CS_number;
The CS_number shall be initialized with 0, io_voltage_in_mV could be removed.

https://review.coreboot.org/c/flashrom/+/72160/comment/1231fa59_611159a8 
PS3, Line 635: 	data->io_voltage_in_mV = io_voltage_in_mV;
data->io_voltage_in_mV = requested_io_voltage_mV;

was intended I think.