Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

View Change

5 comments:

• File ni845x_spi.c:

  • Patch Set #3, Line 432: const struct ni845x_spi_data *data = flash->mst->spi.data;

    I think data shall not be const here. See comments below.

  • Patch Set #3, Line 456: &io_voltage_in_mV,

    The io_voltage_in_mV is not defined anymore. data->io_voltage_in_mV is intended to be used here if I am not mistaken.

  • Patch Set #3, Line 481: &io_voltage_in_mV,

    Same as in line 456

  • Patch Set #3, Line 566: unsigned char CS_number;

    The CS_number shall be initialized with 0, io_voltage_in_mV could be removed.

  • Patch Set #3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV;

    data->io_voltage_in_mV = requested_io_voltage_mV;

    was intended I think.

To view, visit change 72160. To unsubscribe, or for help writing mail filters, visit settings.