Nico Huber has posted comments on this change. ( https://review.coreboot.org/20784 )
Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ......................................................................
Patch Set 1:
(3 comments)
Thanks.
https://review.coreboot.org/#/c/20784/1/pcidev.c File pcidev.c:
https://review.coreboot.org/#/c/20784/1/pcidev.c@262 PS1, Line 262: struct pci_dev * dev; No whitespace after the asterisk, please.
https://review.coreboot.org/#/c/20784/1/pcidev.c@297 PS1, Line 297: Add a comment that `dev` passed to rpci_* has to be compatible to `pacc`. Here and or in the header file?
https://review.coreboot.org/#/c/20784/1/pcidev.c@307 PS1, Line 307: a->domain, a->bus, a->dev, a->func); \ Bail out if `undo_pci_write_data->dev` is NULL or check it in undo_pci_write().