Nico Huber posted comments on this change.

View Change

Patch set 1:

Thanks.

(3 comments)

• File pcidev.c:

  • Patch Set #1, Line 262: struct pci_dev * dev;

    No whitespace after the asterisk, please.

  • Patch Set #1, Line 297:

    Add a comment that `dev` passed to rpci_* has to be compatible
    to `pacc`. Here and or in the header file?

  • Patch Set #1, Line 307: a->domain, a->bus, a->dev, a->func); \

    Bail out if `undo_pci_write_data->dev` is NULL or check it
    in undo_pci_write().

To view, visit change 20784. To unsubscribe, visit settings.