Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 )
Change subject: flashrom: Return early from map_flash for >16MiB on x86 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/56721/comment/5faa4126_15d98c56 PS1, Line 712: programmer_map_flash_region Thank you for the patch!
Here programmer_map_flash_region() is called and that is hooked here
https://github.com/flashrom/flashrom/blob/2376ccf00a805f4744eb830aabdfb7fe8e...
the general physmap() implementation is implemented here
https://github.com/flashrom/flashrom/blob/f41d24823c1703e328fc27588bbcf3c96e...
.
Sine this is platform specific code it probably should be encapsulated within internal.c itself. The flashrom.c implementation is generic dispatch and handling code and so should not really have platform specifics here.
In the chromium tree `-p host` simply just aliases `-p internal` https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/hea...
-
Edward O'Callaghan (Code Review)