Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak.

Patch set 1:Code-Review +1

View Change

1 comment:

• File flashrom.c:

  • Patch Set #1, Line 712: programmer_map_flash_region

    Thank you for the patch!

    Here programmer_map_flash_region() is called and that is hooked here

    https://github.com/flashrom/flashrom/blob/2376ccf00a805f4744eb830aabdfb7fe8e29b7e3/internal.c#L381

    the general physmap() implementation is implemented here

    https://github.com/flashrom/flashrom/blob/f41d24823c1703e328fc27588bbcf3c96eecdbc9/physmap.c#L346

    .

    Sine this is platform specific code it probably should be encapsulated within internal.c itself. The flashrom.c implementation is generic dispatch and handling code and so should not really have platform specifics here.

    In the chromium tree `-p host` simply just aliases `-p internal` https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/heads/master/cros_alias.c#66

To view, visit change 56721. To unsubscribe, or for help writing mail filters, visit settings.