Change in flashrom[master]: flashchips: Add Winbond W25Q64JV..M

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40311 )

Change subject: flashchips: Add Winbond W25Q64JV..M
......................................................................

flashchips: Add Winbond W25Q64JV..M

It is the same as the already-supported W25Q64.V, but Quad I/O is off.
Tested all four PREW functions with a FT2232H.

Change-Id: Ieb16dd5642b47e69e5c5031e3301c4497d42c3d3
Signed-off-by: Angel Pons 
---
M flashchips.c
M flashchips.h
2 files changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/40311/1

diff --git a/flashchips.c b/flashchips.c
index b4006df..79f1e5e 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -17090,6 +17090,46 @@

{
    	.vendor		= "Winbond",
+		.name		= "W25Q64JV..M",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= WINBOND_NEX_ID,
+		.model_id	= WINBOND_NEX_W25Q64JV_M,
+		.total_size	= 8192,
+		.page_size	= 256,
+		/* supports SFDP */
+		/* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.tested		= TEST_OK_PREW,
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {4 * 1024, 2048} },
+				.block_erase = spi_block_erase_20,
+			}, {
+				.eraseblocks = { {32 * 1024, 256} },
+				.block_erase = spi_block_erase_52,
+			}, {
+				.eraseblocks = { {64 * 1024, 128} },
+				.block_erase = spi_block_erase_d8,
+			}, {
+				.eraseblocks = { {8 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_60,
+			}, {
+				.eraseblocks = { {8 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_c7,
+			}
+		},
+		.printlock	= spi_prettyprint_status_register_plain, /* TODO: improve */
+		.unlock		= spi_disable_blockprotect,
+		.write		= spi_chip_write_256,
+		.read		= spi_chip_read,
+		.voltage	= {2700, 3600},
+	},
+
+	{
+		.vendor		= "Winbond",
    	.name		= "W25Q64.W",
    	.bustype	= BUS_SPI,
    	.manufacture_id	= WINBOND_NEX_ID,
diff --git a/flashchips.h b/flashchips.h
index e5ef390..6ddd6f8 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -941,6 +941,7 @@
 #define WINBOND_NEX_W25Q32_W	0x6016	/* W25Q32DW; W25Q32FV in QPI mode */
 #define WINBOND_NEX_W25Q64_W	0x6017	/* W25Q64DW; W25Q64FV in QPI mode */
 #define WINBOND_NEX_W25Q128_W	0x6018	/* W25Q128FW; W25Q128FV in QPI mode */
+#define WINBOND_NEX_W25Q64JV_M	0x7017	/* W25Q64JV_M (QE=0) */
 #define WINBOND_NEX_W25Q128_V_M	0x7018	/* W25Q128JVSM */
 #define WINBOND_NEX_W25Q256JV_M	0x7019	/* W25Q256JV_M (QE=0) */
 #define WINBOND_NEX_W25Q64JW	0x8017

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40311 )

Change subject: flashchips: Add Winbond W25Q64JV..M
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/flashrom/+/40311/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/40311/1//COMMIT_MSG@9 
PS1, Line 9: Quad I/O is off
QE (quad enable) bit is off by default (can be enabled though)

How that compares to other versions is a bit more complex:

FV..G (QE=0), FV..F (QE=0), JV...Q (QE=1, wtf) use 0x40 prefix
FV..Q (QE=1) uses 0x60 prefix
JV...M (QE=0) uses 0x70 prefix

AFAICS

https://review.coreboot.org/c/flashrom/+/40311/1/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/40311/1/flashchips.c@17101 
PS1, Line 17101: FEATURE_WRSR_WREN
I think we should use `FEATURE_WRSR_EWSR` instead. It seems the chip
supports both. But if we use WREN, changes are non-volatile. Also, I
guess with only one of three status registers barely supported by
.printlock and .unlock, it doesn't make much of a difference.

Please test.

[Keith Hui (Code Review)]

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40311 )

Change subject: flashchips: Add Winbond W25Q64JV..M
......................................................................

Patch Set 2:

This is a duplicate of CB:38578. How do we reconcile?

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/40311 )

Change subject: flashchips: Add Winbond W25Q64JV..M
......................................................................

Abandoned