[S] Change in flashrom[master]: writeprotect.c: move wp_bits -> register values/masks conversion into... - flashrom-gerrit

21 Nov 2022


      Attention is currently required from: Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69846 )
Change subject: writeprotect.c: move wp_bits -> register values/masks conversion into func
......................................................................
Patch Set 1:
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/69846/comment/0949b3d6_59b80525 
PS1, Line 170: bit_masks, write_masks
Swapped arguments. Maybe change order of parameters of `get_wp_bits_reg_values()` instead to match `set_reg_bit()`.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/69846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I604478ecbb70392c5584bf5d87c76b6f20f882b1
Gerrit-Change-Number: 69846
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 16:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment