Attention is currently required from: Nikolai Artemiev.
View Change
1 comment:
File writeprotect.c:
Patch Set #1, Line 170: bit_masks, write_masks
Swapped arguments. Maybe change order of parameters of `get_wp_bits_reg_values()` instead to match `set_reg_bit()`.
To view, visit change 69846. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I604478ecbb70392c5584bf5d87c76b6f20f882b1
Gerrit-Change-Number: 69846
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 21 Nov 2022 16:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment