Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56911 )
Change subject: tests: add init_shutdown test for realtek_mst_i2c_spi ......................................................................
Patch Set 4:
(3 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/56911/comment/93a07486_f21850a6 PS3, Line 234: // Only access to I2C address 0x4a is expected
Do we really have one line comments, I am not sure... […]
Changed.
https://review.coreboot.org/c/flashrom/+/56911/comment/a261708b_1c2aa5f5 PS3, Line 252: else if (sz == 1 || sz == 2) : return sz; : else : return -1;
Since you return, else if, and else is not needed
Done
https://review.coreboot.org/c/flashrom/+/56911/comment/be335d23_998bbfc3 PS3, Line 267: io_mock_register(&realtek_mst_io); : run_lifecycle(state, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0"); : io_mock_register(NULL);
This is a small thing, but for consistency and readability, if you could add empty lines between io_ […]
Done