Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
3 comments:
File tests/init_shutdown.c:
Patch Set #3, Line 234: // Only access to I2C address 0x4a is expected
Do we really have one line comments, I am not sure... […]
Changed.
else if (sz == 1 || sz == 2)
return sz;
else
return -1;
Since you return, else if, and else is not needed
Done
io_mock_register(&realtek_mst_io);
run_lifecycle(state, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0");
io_mock_register(NULL);
This is a small thing, but for consistency and readability, if you could add empty lines between io_ […]
Done
To view, visit change 56911. To unsubscribe, or for help writing mail filters, visit settings.