Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 )
Change subject: flashchips: add support for ISSI IS25LP016 ......................................................................
Patch Set 3: Code-Review+1
(10 comments)
Patchset:
PS3: In the meantime we have replaced some function pointers with enums. This needs to be fixed in your patch. Otherwise looks good to me.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68295/comment/4c04b7ad_45b45559 PS3, Line 7487: probe_spi_rdid PROBE_SPI_RDID
https://review.coreboot.org/c/flashrom/+/68295/comment/1e0aa3f4_fb442d95 PS3, Line 7493: spi_block_erase_20 SPI_BLOCK_ERASE_20
https://review.coreboot.org/c/flashrom/+/68295/comment/9f866217_2574998e PS3, Line 7496: spi_block_erase_d7 SPI_BLOCK_ERASE_D7
https://review.coreboot.org/c/flashrom/+/68295/comment/a3edc858_411151b8 PS3, Line 7499: spi_block_erase_52 SPI_BLOCK_ERASE_52
https://review.coreboot.org/c/flashrom/+/68295/comment/6332c96b_8f32089e PS3, Line 7502: spi_block_erase_d8 SPI_BLOCK_ERASE_D8
https://review.coreboot.org/c/flashrom/+/68295/comment/2ccc021d_c02964cc PS3, Line 7505: spi_block_erase_60 SPI_BLOCK_ERASE_60
https://review.coreboot.org/c/flashrom/+/68295/comment/a07b7d04_e5e4cb5f PS3, Line 7508: spi_block_erase_c7 SPI_BLOCK_ERASE_C7
https://review.coreboot.org/c/flashrom/+/68295/comment/d5d840bc_2e7e0a9d PS3, Line 7512: spi_chip_write_256 SPI_CHIP_WRITE256
https://review.coreboot.org/c/flashrom/+/68295/comment/7c2bfef7_6b6f773f PS3, Line 7513: spi_chip_read SPI_CHIP_READ
-
Felix Singer (Code Review)