Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer.

Patch set 3:Code-Review +1

View Change

10 comments:

• Patchset:

  • Patch Set #3:

    In the meantime we have replaced some function pointers with enums. This needs to be fixed in your patch. Otherwise looks good to me.

• File flashchips.c:

  • Patch Set #3, Line 7487: probe_spi_rdid

    PROBE_SPI_RDID

  • Patch Set #3, Line 7493: spi_block_erase_20

    SPI_BLOCK_ERASE_20

  • Patch Set #3, Line 7496: spi_block_erase_d7

    SPI_BLOCK_ERASE_D7

  • Patch Set #3, Line 7499: spi_block_erase_52

    SPI_BLOCK_ERASE_52

  • Patch Set #3, Line 7502: spi_block_erase_d8

    SPI_BLOCK_ERASE_D8

  • Patch Set #3, Line 7505: spi_block_erase_60

    SPI_BLOCK_ERASE_60

  • Patch Set #3, Line 7508: spi_block_erase_c7

    SPI_BLOCK_ERASE_C7

  • Patch Set #3, Line 7512: spi_chip_write_256

    SPI_CHIP_WRITE256

  • Patch Set #3, Line 7513: spi_chip_read

    SPI_CHIP_READ

To view, visit change 68295. To unsubscribe, or for help writing mail filters, visit settings.