Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
Patch Set 6:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/577bd9ff_a74b5140
PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
This is a good suggestion. But I have no better solution yet.
It's as I feared: If you run `make` two times in a row without this
patch, the second run detects that there is nothing to do. With the
patch, everything is built all over again.
I could guide you through Makefile syntax and semantics, but it's
probably only worth the educational effect. Time might be better
spent to remove the need for this.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/49599/comment/6009511f_ac2c642e
PS4, Line 43: #include "programmer_table.c"
Yes, this may cause some problems. […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Xiang Wang
merle@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 22 Mar 2021 22:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Xiang Wang
merle@hardenedlinux.org
Gerrit-MessageType: comment