Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer.

View Change

2 comments:

• File Makefile:

  • Patch Set #4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)

    This is a good suggestion. But I have no better solution yet.

    It's as I feared: If you run `make` two times in a row without this
    patch, the second run detects that there is nothing to do. With the
    patch, everything is built all over again.

    I could guide you through Makefile syntax and semantics, but it's
    probably only worth the educational effect. Time might be better
    spent to remove the need for this.

• File flashrom.c:

  • Patch Set #4, Line 43: #include "programmer_table.c"

    Yes, this may cause some problems. […]

    Ack

To view, visit change 49599. To unsubscribe, or for help writing mail filters, visit settings.