Attention is currently required from: Thomas Heijligen, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel ......................................................................
Patch Set 3:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/a5ba1dbd_d97cadbd PS3, Line 104: CONFIG_INTERNAL_MIPSLE \ Is this actually true?
https://review.coreboot.org/c/flashrom/+/61300/comment/d284d3d3_5073a47c PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
I think this is overly strict, because the internal programmer will delegate to MTD if enabled, whic […]
Sounds like it compiled with the meson.build by coincidence all the time? Looking at the code, it seems possible, but there's a shitload of dead, code not making any sense.
I guess we could have a CONFIG_INTERNAL (with raw mem and libpci (spurious?) dependencies) and CONFIG_INTERNAL_X86 like suggested by this patch. Thomas, WDYT? For the dependencies, we'd have to disable CONFIG_INTERNAL if CONFIG_INTERNAL_X86 = no.
-
Nico Huber (Code Review)