Attention is currently required from: Thomas Heijligen, Peter Marheine.

View Change

2 comments:

• File Makefile:

  • Patch Set #3, Line 104: CONFIG_INTERNAL_MIPSLE \

    Is this actually true?

  • Patch Set #3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)

    I think this is overly strict, because the internal programmer will delegate to MTD if enabled, whic […]

    Sounds like it compiled with the meson.build by coincidence all the time?
    Looking at the code, it seems possible, but there's a shitload of dead,
    code not making any sense.

    I guess we could have a CONFIG_INTERNAL (with raw mem and libpci (spurious?) dependencies) and CONFIG_INTERNAL_X86 like suggested by this patch. Thomas,
    WDYT? For the dependencies, we'd have to disable CONFIG_INTERNAL if
    CONFIG_INTERNAL_X86 = no.

To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.