Attention is currently required from: Simon Buhrow, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67354 )
Change subject: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list ......................................................................
Patch Set 8:
(6 comments)
Patchset:
PS8: Can you reorder the commits that this patch comes after the other spi.c patch
File spi.c:
https://review.coreboot.org/c/flashrom/+/67354/comment/0f45e269_9b692de9 PS8, Line 31: uint8_t opcode[MAX_OPCODE]; Please add a comment how the array is working
https://review.coreboot.org/c/flashrom/+/67354/comment/3ce6fd07_f6694ea7 PS8, Line 31: [MAX_OPCODE This can be an inline number or defined locally.
https://review.coreboot.org/c/flashrom/+/67354/comment/57eb8d7b_15d7d210 PS8, Line 49: 0x00} Just use `0` to make clear it's a terminator
https://review.coreboot.org/c/flashrom/+/67354/comment/5d8cc249_f1af46f3 PS8, Line 70: ) Would be good to have the length of the list (`opcode_count`) as parameter. Then the caller does not need to care about the number of opcodes in the list.
https://review.coreboot.org/c/flashrom/+/67354/comment/026b366e_1a353ead PS8, Line 85: Please add documentation about the function that everyone who want's to use or work with it understands what it will return and how to use the result. Have a look at the function doc in include/libflashrom.h