Attention is currently required from: Simon Buhrow, Aarya.
6 comments:
Patchset:
Can you reorder the commits that this patch comes after the other spi.c patch
File spi.c:
Patch Set #8, Line 31: uint8_t opcode[MAX_OPCODE];
Please add a comment how the array is working
Patch Set #8, Line 31: [MAX_OPCODE
This can be an inline number or defined locally.
Patch Set #8, Line 49: 0x00}
Just use `0` to make clear it's a terminator
Would be good to have the length of the list (`opcode_count`) as parameter. Then the caller does not need to care about the number of opcodes in the list.
Please add documentation about the function that everyone who want's to use or work with it understands what it will return and how to use the result. Have a look at the function doc in include/libflashrom.h
To view, visit change 67354. To unsubscribe, or for help writing mail filters, visit settings.