Attention is currently required from: Nico Huber, Thomas Heijligen, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64747 )
Change subject: flashchips: Add Spansion (today Infineon) S25FL128L and S25FL256L ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/64747/comment/1060e033_824b4417 PS2, Line 16718: /* : * Note: This chip has a read-only Status Register 2 that is not : * counted here. Registers are mapped as follows: : * STATUS1 ... Status Register 1 : * STATUS2 ... Configuration Register 1 : * STATUS3 ... Configuration Register 2 : */ An alternative here would be to define to define CONFIG{1,2} registers, but I don't know of other chips that have similar config registers so adding them might not be worth it.