Attention is currently required from: Nico Huber, Thomas Heijligen, Sergii Dmytruk.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 16718:
/*
* Note: This chip has a read-only Status Register 2 that is not
* counted here. Registers are mapped as follows:
* STATUS1 ... Status Register 1
* STATUS2 ... Configuration Register 1
* STATUS3 ... Configuration Register 2
*/
An alternative here would be to define to define CONFIG{1,2} registers, but I don't know of other chips that have similar config registers so adding them might not be worth it.
To view, visit change 64747. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I356df6649f29e50879a4da4183f1164a81cb0a09
Gerrit-Change-Number: 64747
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Tue, 31 May 2022 23:06:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment