Attention is currently required from: Stanislav Ponomarev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79112?usp=email )
Change subject: serial: Fix sp_flush_incoming for serprog TCP connections ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Patchset:
PS2:
Thank you for your detailed review! […]
This is not the first time I see "Name of user not set", I think this means it's time to update the documentation. I created a patch CB:79250 and added you, you can vote +1 or add comments. Thank you!
File serial.c:
https://review.coreboot.org/c/flashrom/+/79112/comment/49c30cfc_5fce4d9b : PS2, Line 401: return;
yeah, i'm a bit uncomfortable with this too, but i actually have no idea what to do if something els […]
It looks good now. Thank you for detailed comments in the code. And FIXME is definitely is not needed anymore, we have an error handling now!
-
Anastasia Klimchuk (Code Review)