Attention is currently required from: Stanislav Ponomarev.

Patch set 4:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    Thank you for your detailed review! […]

    This is not the first time I see "Name of user not set", I think this means it's time to update the documentation. I created a patch CB:79250 and added you, you can vote +1 or add comments. Thank you!

• File serial.c:

  • Patch Set #2, Line 401: return;

    yeah, i'm a bit uncomfortable with this too, but i actually have no idea what to do if something els […]

    It looks good now. Thank you for detailed comments in the code.
    And FIXME is definitely is not needed anymore, we have an error handling now!

To view, visit change 79112. To unsubscribe, or for help writing mail filters, visit settings.