Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email )
Change subject: flashchips: change chip lock status funcs for Winbond chips ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/75877/comment/e59640fd_32f67417 : PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I agree, `AMIC_A25L032` doesn't seem like the right printlock function for a winbond chip. […]
I opened datasheets and looked up the function that allows to display all the data from the Status Register.
Functions with `PRETTYPRINT` prefix DO only print values from the Status Register-1, so an inappropriate function can only disguise a user.
How about renaming to `SPI_PRETTYPRINT_STATUS_REGISTER_BP2_TB_SEC_SRWD`?
Datasheets are available there: https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flas...