Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I agree, `AMIC_A25L032` doesn't seem like the right printlock function for a winbond chip. […]
I opened datasheets and looked up the function that allows to display all the data from the Status Register.
Functions with `PRETTYPRINT` prefix DO only print values from the Status Register-1, so an inappropriate function can only disguise a user.
How about renaming to `SPI_PRETTYPRINT_STATUS_REGISTER_BP2_TB_SEC_SRWD`?
Datasheets are available there: https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en
To view, visit change 75877. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49
Gerrit-Change-Number: 75877
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 14 Jul 2023 23:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment