Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52283 )
Change subject: linux_spi.c: Extract get_max_kernel_buf_size() as a function ......................................................................
Patch Set 1:
(1 comment)
File linux_spi.c:
https://review.coreboot.org/c/flashrom/+/52283/comment/478435d1_24c5304e PS1, Line 169: const uint8_t bits = 8;
missing the line: […]
Oh, I can explain why this line is not here. At this patch, max_kernel_buf_size is still a global state (together with fd), they are defined in lines 47, 49. I am not removing global state in this patch, so I left it as is, and since max_kernel_buf_size is global I don't need to define it locally in init function.
I do remove global state later in https://review.coreboot.org/c/flashrom/+/52285 , but not here.
What do you think about it? I was trying to keep the purpose for each patch very focused.