Attention is currently required from: Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File linux_spi.c:

  • Patch Set #1, Line 169: const uint8_t bits = 8;

    missing the line: […]

    Oh, I can explain why this line is not here. At this patch, max_kernel_buf_size is still a global state (together with fd), they are defined in lines 47, 49. I am not removing global state in this patch, so I left it as is, and since max_kernel_buf_size is global I don't need to define it locally in init function.

    I do remove global state later in https://review.coreboot.org/c/flashrom/+/52285 , but not here.

    What do you think about it? I was trying to keep the purpose for each patch very focused.

To view, visit change 52283. To unsubscribe, or for help writing mail filters, visit settings.