Attention is currently required from: Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70539 )
Change subject: layout: Extract parsing include args into a separate function ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File layout.c:
https://review.coreboot.org/c/flashrom/+/70539/comment/3b7a1fdf_8563bf4f PS1, Line 117: bool Hmmm, returning an error code would've involved changing less things, but it's not a big deal. We don't seem to have any rules to prefer returning error codes (success is 0) or boolean success/failure (success is not-0, aka true), but the former style seems more common in flashrom.
No changes needed, just sharing our thoughts.