Attention is currently required from: Anastasia Klimchuk.

Patch set 1:Code-Review +2

View Change

1 comment:

• File layout.c:

  • Patch Set #1, Line 117: bool

    Hmmm, returning an error code would've involved changing less things, but it's not a big deal. We don't seem to have any rules to prefer returning error codes (success is 0) or boolean success/failure (success is not-0, aka true), but the former style seems more common in flashrom.

    No changes needed, just sharing our thoughts.

To view, visit change 70539. To unsubscribe, or for help writing mail filters, visit settings.