Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops - flashrom-gerrit

26 Sep 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/21702 )
Change subject: nicintel_eeprom: Move variable declarations out of loops
......................................................................
Patch Set 1: Code-Review+2
...
We do not (want to) support non-C99 compilers and I seriously doubt
that this is really the issue and thus the best fix. Can you please
show us the compiler's diagnostics and build_details.txt?
Well, we kept the code compatible until now and as long as we don't
specify the standard, should keep it that way.
-- 
To view, visit https://review.coreboot.org/21702
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31
Gerrit-Change-Number: 21702
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Sep 2017 17:48:44 +0000
Gerrit-HasComments: No