Nico Huber posted comments on this change.

View Change

Patch set 1:Code-Review +2

We do not (want to) support non-C99 compilers and I seriously doubt
that this is really the issue and thus the best fix. Can you please
show us the compiler's diagnostics and build_details.txt?

Well, we kept the code compatible until now and as long as we don't
specify the standard, should keep it that way.

To view, visit change 21702. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31
Gerrit-Change-Number: 21702
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 26 Sep 2017 17:48:44 +0000
Gerrit-HasComments: No