Attention is currently required from: David Reguera Garcia.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79405?usp=email )
Change subject: buspirate_spi: Stop execution when invalid params ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/79405/comment/3ba96206_92280869 : PS1, Line 7: Stop execution when invalid params Return init error for invalid values of pullups, hiz, psus
https://review.coreboot.org/c/flashrom/+/79405/comment/ff7636da_68ef2884 : PS1, Line 8: Maybe you can add a little clarifying paragraph here in commit message, for example:
Previously, invalid values of the params pullups, hiz, psus were handled as "off" (i.e. disabled). This created a potential human error when users were running flashrom with e.g. `pullups=1` and expected pullups to be on, while the value `1` was handled as invalid and off.
File buspirate_spi.c:
https://review.coreboot.org/c/flashrom/+/79405/comment/e7e1a03a_cc598b9d : PS1, Line 380: return You need to `free(tmp)` before returning (and same for two other places below)
-
Anastasia Klimchuk (Code Review)