Attention is currently required from: David Reguera Garcia.
3 comments:
Commit Message:
Patch Set #1, Line 7: Stop execution when invalid params
Return init error for invalid values of pullups, hiz, psus
Maybe you can add a little clarifying paragraph here in commit message, for example:
Previously, invalid values of the params pullups, hiz, psus were handled as "off" (i.e. disabled). This created a potential human error when users were running flashrom with e.g. `pullups=1` and expected pullups to be on, while the value `1` was handled as invalid and off.
File buspirate_spi.c:
Patch Set #1, Line 380: return
You need to `free(tmp)` before returning (and same for two other places below)
To view, visit change 79405. To unsubscribe, or for help writing mail filters, visit settings.