Attention is currently required from: Nico Huber, Paul Menzel, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm ......................................................................
Patch Set 43:
(7 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/acba3b97_7d3946f9 PS43, Line 1054: assert(!ret); ``` if (ret) { msg_cerr("Failed to execute erase command for offset %#x to %#x.\n", start_addr, end_addr); return -1; } ```
https://review.coreboot.org/c/flashrom/+/66104/comment/7adf04b3_224d43cb PS43, Line 1055: //verify erase : ret = check_erased_range(flashctx, start_addr, block_len); : assert(!ret); : //if erase fail?? : // This is not needed, there is a verify command at the end.
https://review.coreboot.org/c/flashrom/+/66104/comment/5f66e748_159c9682 PS43, Line 1065: msg_cinfo s/msg_cdbg/
https://review.coreboot.org/c/flashrom/+/66104/comment/71a023b6_71f261ef PS43, Line 1076: assert(!ret); ``` if (ret) { msg_cerr("Write failed at %#x, Abort.\n", i); return -1; } ```
https://review.coreboot.org/c/flashrom/+/66104/comment/f54c5f41_fb3e9f65 PS43, Line 1078: ret = verify_range(flashctx, newcontents + i, i, flashctx->chip->page_size); : assert(!ret); This is not needed, there is a verify command at the end.
https://review.coreboot.org/c/flashrom/+/66104/comment/ba2b1ffb_94ec0338 PS43, Line 1082: msg_cinfo s/msg_cdbg/
https://review.coreboot.org/c/flashrom/+/66104/comment/c2c22c1e_57208830 PS43, Line 1088: assert(!ret); ``` if (ret) { msg_cerr("Verifying flash failed failed for range %#x : %#x, Abort.\n", region_start, region_end); return -1; } ```