Attention is currently required from: Nico Huber, Paul Menzel, Aarya.

View Change

7 comments:

• File flashrom.c:

  • Patch Set #43, Line 1054: assert(!ret);

    ```
    if (ret) {
        msg_cerr("Failed to execute erase command for offset %#x to %#x.\n", start_addr, end_addr);
        return -1;
    }
    ```

  • Patch Set #43, Line 1055:

    //verify erase
    				ret = check_erased_range(flashctx, start_addr, block_len);
    				assert(!ret);
    				//if erase fail??
    				//
    

    This is not needed, there is a verify command at the end.

  • Patch Set #43, Line 1065: msg_cinfo

    s/msg_cdbg/

  • Patch Set #43, Line 1076: assert(!ret);

    ```
    if (ret) {
        msg_cerr("Write failed at %#x, Abort.\n", i);
        return -1;
    }
    ```

  • Patch Set #43, Line 1078:

    ret = verify_range(flashctx, newcontents + i, i, flashctx->chip->page_size);
    			assert(!ret);
    

    This is not needed, there is a verify command at the end.

  • Patch Set #43, Line 1082: msg_cinfo

    s/msg_cdbg/

  • Patch Set #43, Line 1088: assert(!ret);

    ```
    if (ret) {
        msg_cerr("Verifying flash failed failed for range %#x : %#x, Abort.\n", region_start, region_end);
        return -1;
    }
    ```

To view, visit change 66104. To unsubscribe, or for help writing mail filters, visit settings.