[M] Change in flashrom[master]: tree/: Move programmer_delay() out of programmer state machine

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67393 )

Change subject: tree/: Move programmer_delay() out of programmer state machine
......................................................................

Patch Set 9:

(2 comments)

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/67393/comment/b32f921b_114e240a 
PS9, Line 265: 	if (flash->mst->buses_supported & BUS_SPI) {
             : 		if (flash->mst->spi.delay)
             : 			flash->mst->spi.delay(flash, usecs);
             : 	} else if (flash->mst->buses_supported & BUS_PARALLEL) {
             : 		if (flash->mst->par.delay)
             : 			flash->mst->par.delay(flash, usecs);
             : 	} else
             : 		internal_delay(usecs);
> This changes the logic, it seems to me? […]

Isn't this logically equivalent? Also delay functions have a void return type.

File serprog.c:

https://review.coreboot.org/c/flashrom/+/67393/comment/dcac7b87_063715e9 
PS9, Line 456: static void serprog_delay(const struct flashctx *flash, unsigned int usecs);
> I am missing something, why the static forward declaration is needed? Can it be the `serprog_delay`  […]

`serprog_delay()` uses `sp_check_opbuf_usage()` and that is below this struct. I am avoiding reshuffling so much of the file.