Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #9, Line 265:

    	if (flash->mst->buses_supported & BUS_SPI) {
    		if (flash->mst->spi.delay)
    			flash->mst->spi.delay(flash, usecs);
    	} else if (flash->mst->buses_supported & BUS_PARALLEL) {
    		if (flash->mst->par.delay)
    			flash->mst->par.delay(flash, usecs);
    	} else
    		internal_delay(usecs);
    

    This changes the logic, it seems to me? […]

    Isn't this logically equivalent? Also delay functions have a void return type.

• File serprog.c:

  • Patch Set #9, Line 456: static void serprog_delay(const struct flashctx *flash, unsigned int usecs);

    I am missing something, why the static forward declaration is needed? Can it be the `serprog_delay` […]

    `serprog_delay()` uses `sp_check_opbuf_usage()` and that is below this struct. I am avoiding reshuffling so much of the file.

To view, visit change 67393. To unsubscribe, or for help writing mail filters, visit settings.