Attention is currently required from: Aarya, Bill XIE.
Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email )
Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS3:
Okay.
Done
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84721/comment/a1514ad8_3b4bbe3c?usp... : PS5, Line 126: max 100 What do you think about restricting max to 50? I don't think values more than 50 make sense.
https://review.coreboot.org/c/flashrom/+/84721/comment/dd660fbd_5cc0dcec?usp... : PS5, Line 1141: Invalid input of sacrifice ratio, use default 0 Invalid input of sacrifice ratio, valid range is 0-50. Fallback to default value 0.
(that's if you agree with previous comment)