Attention is currently required from: Aarya, Bill XIE.
View Change
3 comments:
Patchset:
File cli_classic.c:
Patch Set #5, Line 126: max 100
What do you think about restricting max to 50? I don't think values more than 50 make sense.
Patch Set #5, Line 1141: Invalid input of sacrifice ratio, use default 0
Invalid input of sacrifice ratio, valid range is 0-50. Fallback to default value 0.
(that's if you agree with previous comment)
To view, visit change 84721. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803
Gerrit-Change-Number: 84721
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Fri, 25 Oct 2024 10:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE <persmule@hardenedlinux.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>